Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim modules #17

Merged
merged 10 commits into from
Dec 16, 2024
Merged

Trim modules #17

merged 10 commits into from
Dec 16, 2024

Conversation

lu-pinto
Copy link

@lu-pinto lu-pinto commented Dec 13, 2024 •
edited
Loading

PR description

Trims down the project to only include the following modules, and others that these depend on:

tuweni-bytes
tuweni-config
tuweni-concurrent
tuweni-crypto
tuweni-devp2p
tuweni-io
tuweni-net
tuweni-rlp
tuweni-toml
tuweni-units
tuweni-ssz

Fixed Issue(s)

fixes #15

macfarla and others added 10 commits November 21, 2024 16:28
@macfarla
rm redis
d99d768 
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla
rm scuttlebutt
a66fdde 
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla
rm hobbits
a36f10f 
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla
removed references to removed modules
e5df353 
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla
rm wallet eth-faucet
405d4a9 
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla
remove ssb integration tests workflow
9e74c74 
Signed-off-by: Sally MacFarlane <[email protected]>
@lu-pinto
remove les eth-crawler eth-client* devp2p-eth
5855cb1 
Signed-off-by: Luis Pinto <[email protected]>
@lu-pinto
remove devp2p-proxy dns-discovery
65811ab 
Signed-off-by: Luis Pinto <[email protected]>
@lu-pinto
rm eth* jsonrpc* stratum* genesis evm*
726f0e3 
Signed-off-by: Luis Pinto <[email protected]>
@lu-pinto
rm app-commons metrics peer-repository rlpx pow plumtree*
a921338 
Signed-off-by: Luis Pinto <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Dec 13, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lu-pinto lu-pinto requested a review from macfarla December 13, 2024 11:26
garyschulte
garyschulte approved these changes Dec 14, 2024
View reviewed changes
Copy link

@garyschulte garyschulte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMMFG

image

@garyschulte
Copy link

one thing though - I believe we invested in tuweni-ssz to make it robust enough for a besu ssz implementation. We might want to keep that

@macfarla macfarla mentioned this pull request Dec 15, 2024
Closed
@lu-pinto
Copy link
Author

one thing though - I believe we invested in tuweni-ssz to make it robust enough for a besu ssz implementation. We might want to keep that

Not sure I understand, I didn't remove ssz. So you want to keep or remove? Teku seems to be using it

@garyschulte
Copy link

Not sure I understand, I didn't remove ssz. So you want to keep or remove? Teku seems to be using it

My bad - I read tuweni-ssz as removed, not kept. 👍

@lu-pinto lu-pinto merged commit 780b7ee into Consensys:main Dec 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyschulte garyschulte garyschulte approved these changes

@macfarla macfarla Awaiting requested review from macfarla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trim down to required modules
4 participants
@lu-pinto @CLAassistant @garyschulte @macfarla